Update search match colors in notebook and text document #6155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Looks good to me. Thanks! Flagging the ux team for comments in the next day or two. Otherwise I'll merge and we can iterate on the design. |
|
CC @tgeorgeux, @ellisonbg |
jasongrout
approved these changes
Apr 2, 2019
|
We'll do a UX review before the final release, so I'll merge this to keep things progressing. |
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the highlight colors for search matches in notebooks and in text files (any searchable widget using CodeMirror). To get the extra highlighting, I had to turn on the
styleSelectedTextoption by default. When this is turned on, CodeMirror applies a class,CodeMirror-selectedtext, to the selected section of text. I used this as well as thecm-searchingclass that gets applied to the text by the search mode to apply custom styling to the selected and unselected matches.Light theme screenshot:
Dark theme screenshot:
